standalone and limit-debug-info are the same functionality - -fstandalone-debug is the more modern and apt description, so perhaps just keep that one & drop/don't provide -flimit-debug-info (since there's no real need to be backwards compatible in the flag support in clang-cl, I expect)?
On Fri, Sep 9, 2016 at 9:51 AM Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rnk > Date: Fri Sep 9 11:42:50 2016 > New Revision: 281056 > > URL: http://llvm.org/viewvc/llvm-project?rev=281056&view=rev > Log: > Make -fstandalone-debug and -flimit-debug-info available in clang-cl > > Our limited debug info optimizations are breaking down at DLL > boundaries, so we're going to evaluate the size impact of these > settings, and possibly change the default. > > Users should be able to override our settings, though. > > Modified: > cfe/trunk/include/clang/Driver/Options.td > cfe/trunk/test/Driver/cl-options.c > > Modified: cfe/trunk/include/clang/Driver/Options.td > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/Options.td?rev=281056&r1=281055&r2=281056&view=diff > > ============================================================================== > --- cfe/trunk/include/clang/Driver/Options.td (original) > +++ cfe/trunk/include/clang/Driver/Options.td Fri Sep 9 11:42:50 2016 > @@ -1138,12 +1138,12 @@ def fstack_protector_strong : Flag<["-"] > HelpText<"Use a strong heuristic to apply stack protectors to > functions">; > def fstack_protector : Flag<["-"], "fstack-protector">, Group<f_Group>, > HelpText<"Enable stack protectors for functions potentially vulnerable > to stack smashing">; > -def fstandalone_debug : Flag<["-"], "fstandalone-debug">, Group<f_Group>, > +def fstandalone_debug : Flag<["-"], "fstandalone-debug">, Group<f_Group>, > Flags<[CoreOption]>, > HelpText<"Emit full debug info for all types used by the program">; > -def fno_standalone_debug : Flag<["-"], "fno-standalone-debug">, > Group<f_Group>, > +def fno_standalone_debug : Flag<["-"], "fno-standalone-debug">, > Group<f_Group>, Flags<[CoreOption]>, > HelpText<"Limit debug information produced to reduce size of debug > binary">; > -def flimit_debug_info : Flag<["-"], "flimit-debug-info">, > Alias<fno_standalone_debug>; > -def fno_limit_debug_info : Flag<["-"], "fno-limit-debug-info">, > Alias<fstandalone_debug>; > +def flimit_debug_info : Flag<["-"], "flimit-debug-info">, > Flags<[CoreOption]>, Alias<fno_standalone_debug>; > +def fno_limit_debug_info : Flag<["-"], "fno-limit-debug-info">, > Flags<[CoreOption]>, Alias<fstandalone_debug>; > def fstrict_aliasing : Flag<["-"], "fstrict-aliasing">, Group<f_Group>, > Flags<[DriverOption, CoreOption]>; > def fstrict_enums : Flag<["-"], "fstrict-enums">, Group<f_Group>, > Flags<[CC1Option]>, > > Modified: cfe/trunk/test/Driver/cl-options.c > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/cl-options.c?rev=281056&r1=281055&r2=281056&view=diff > > ============================================================================== > --- cfe/trunk/test/Driver/cl-options.c (original) > +++ cfe/trunk/test/Driver/cl-options.c Fri Sep 9 11:42:50 2016 > @@ -518,6 +518,8 @@ > // RUN: -resource-dir \ > // RUN: -Wunused-variable \ > // RUN: -fmacro-backtrace-limit=0 \ > +// RUN: -fstandalone-debug \ > +// RUN: -flimit-debug-info \ > // RUN: -Werror /Zs -- %s 2>&1 > > > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
