aaron.ballman added inline comments.

================
Comment at: clang/include/clang/AST/Attr.h:87-99
+  enum class Variety {
+    None,
+    GNU,          // __attribute__((...))
+    Declspec,     // __declspec(...)
+    Microsoft,    // [...]
+    CXX11,        // [[...]]
+    C2x,          // [[...]]
----------------
I don't think either of these are needed -- `Attr` inherits from 
`AttributeCommonInfo` and that base class already has 
`AttributeCommonInfo::getSyntax()` for getting this information. Will that work 
for your needs?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157384/new/

https://reviews.llvm.org/D157384

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to