carlosgalvezp accepted this revision. carlosgalvezp added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang-tools-extra/clang-tidy/performance/NoexceptSwapCheck.cpp:22 Finder->addMatcher( - functionDecl(unless(isDeleted()), hasName("swap")).bind(BindFuncDeclName), + functionDecl( + unless(isDeleted()), hasName("swap"), ---------------- Would be good to add a small comment summarizing what signatures this block of code matches, for easier readability. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157185/new/ https://reviews.llvm.org/D157185 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits