djasper added inline comments.
================
Comment at: lib/Format/WhitespaceManager.cpp:47
@@ +46,3 @@
+
+int WhitespaceManager::Change::ScopeLevel() const {
+ // NestingLevel is raised on the opening paren/square, and remains raised
----------------
What I don't understand is why you have to combine NestingLevel and IndentLevel
at all. To me it feels wrong to add them no matter what (with and without your
extra bit of logic).
IMO, for alignment, we should ensure that both NestingLevel *and* IndentLevel
are the same, not just the the sum of the two is the same. That's why I was
suggesting putting them into a pair and just comparing the pair. But I might be
missing something very obvious.
https://reviews.llvm.org/D21279
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
