arsenm added inline comments.
================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:17146
+ Value *ABIVersion;
+ if (ABIVersionC) {
+ ABIVersion = CGF.Builder.CreateAlignedLoad(CGF.Int32Ty, ABIVersionC,
----------------
this must always pass
================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp:3037
+ if (getImplicitArgsSize() < utils::COV5_SIZE) {
+ DP("Setting fields of ImplicitArgs for COV4\n");
+ } else {
----------------
This isn't doing anything?
================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/utils/UtilitiesRTL.h:36
-// The implicit arguments of AMDGPU kernels.
-struct AMDGPUImplicitArgsTy {
- uint64_t OffsetX;
- uint64_t OffsetY;
- uint64_t OffsetZ;
- uint64_t HostcallPtr;
- uint64_t Unused0;
- uint64_t Unused1;
- uint64_t Unused2;
+enum IMPLICITARGS : uint32_t {
+ COV4_SIZE = 56,
----------------
This is getting duplicated a few places, should it move to a support header?
I don't love the existing APIs for this, I think a struct definition makes more
sense
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139730/new/
https://reviews.llvm.org/D139730
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
