bnbarham added a comment.

> Are there other users of incremental processing mode, other than the REPL / 
> IncrementalParser?

It seems Swift's clang importer also uses incremental processing mode, I'm 
assuming to keep the `TUScope` and `CurLexer` alive after EOF. We also end up 
using the same context with various actions, which leads to a few hangs as 
there's various checks for `eof` only, eg. `ReadPCHAndPreprocessAction`, 
`PreprocessOnlyAction`, and `RewriteIncludesAction`. There's also quite a few 
places in the parser that only check for `eof` as well (I just grepped for 
`Tok.isNot(tok::eof)`).

Should these all be updated to handle `annot_repl_input_end` or should we 
instead have a different flag that we set for this purpose instead of co-opting 
`isIncrementalProcessingEnabled`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148997/new/

https://reviews.llvm.org/D148997

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to