donat.nagy accepted this revision.
donat.nagy added a comment.
This revision is now accepted and ready to land.
LGTM, with a little bikeshedding ;-)
================
Comment at: clang/test/Analysis/enum-cast-out-of-range.cpp:203
+
+enum class empty_unfixed {};
+
----------------
Consider using "specified" and "unspecified" instead of "fixed" and "unfixed",
because the rest of the test file uses them and in my opinion "unfixed" looks
strange in this context. (I know that e.g.
https://en.cppreference.com/w/cpp/language/enum speaks about "fixed" underlying
context, but it doesn't use "unfixed".)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153954/new/
https://reviews.llvm.org/D153954
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
