arsenm added a comment.
missing tests
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1066
+ if (!IsCC1As) {
+ std::string CodeObjVerStr = (CodeObjVer ? Twine(CodeObjVer) :
"none").str();
CmdArgs.insert(CmdArgs.begin() + 1,
----------------
don't need to go through std::string? stick with Twine everywhere?
================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:2309
+ auto CovStr = StringRef(CodeObjArg->getValue());
+ if(CovStr.starts_with("none")) return;
+
----------------
missing space after if, also return on separate line. Also why starts with, and
not ==?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156928/new/
https://reviews.llvm.org/D156928
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
