yaxunl added a comment. In D156363#4554693 <https://reviews.llvm.org/D156363#4554693>, @jhuber6 wrote:
> In D156363#4554687 <https://reviews.llvm.org/D156363#4554687>, @yaxunl wrote: > >> In D156363#4554435 <https://reviews.llvm.org/D156363#4554435>, @jhuber6 >> wrote: >> >>> Clang :: Driver/amdgpu-hip-system-arch.c >>> Clang :: Driver/cuda-bad-arch.cu >>> Clang :: Driver/hip-autolink.hip >>> Clang :: Driver/hip-binding.hip >>> Clang :: Driver/hip-cuid-hash.hip >>> Clang :: Driver/hip-cuid.hip >>> Clang :: Driver/hip-default-gpu-arch.hip >>> Clang :: Driver/hip-device-compile.hip >>> Clang :: Driver/hip-host-cpu-features.hip >>> Clang :: Driver/hip-launch-api.hip >>> Clang :: Driver/hip-link-bc-to-bc.hip >>> Clang :: Driver/hip-link-bundle-archive.hip >>> Clang :: Driver/hip-no-device-libs.hip >>> Clang :: Driver/hip-options.hip >>> Clang :: Driver/hip-output-file-name.hip >>> Clang :: Driver/hip-printf.hip >>> Clang :: Driver/hip-save-temps.hip >>> Clang :: Driver/hip-std.hip >>> Clang :: Driver/hip-syntax-only.hip >>> Clang :: Driver/hip-toolchain-dwarf.hip >>> Clang :: Driver/hip-toolchain-features.hip >>> Clang :: Driver/hip-toolchain-mllvm.hip >>> Clang :: Driver/hip-toolchain-opt.hip >>> Clang :: Driver/lto.cu >>> Clang :: Driver/openmp-offload-gpu.c >>> Clang :: Driver/openmp-offload-infer.c >>> Clang :: Driver/rocm-detect.hip >>> >>> These are the tests I'm seeing fail locally. >> >> These tests fail because the lit tests expect clang driver to run without >> ROCm. >> >> I will update these tests so that they pass on systems with or w/o ROCm. > > I've got a patch half done that mostly adds `-nogpuinc` to all these run > lines. Thanks. I will wait for your patch. You can leave the tricky ones to me if you would like. e.g. the rocm-detect.hip Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156363/new/ https://reviews.llvm.org/D156363 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
