NoQ added inline comments.
================ Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1143 + // order is deterministic: + CompareNode<VarDecl>> + byVar; ---------------- t-rasmud wrote: > NoQ wrote: > > ziqingluo-90 wrote: > > > To make the order of variables in every group deterministic. > > Would it make sense to immediately clean up the regexps in tests then? > @NoQ I had an offline discussion with @ziqingluo-90 about this and we agreed > (IIRC) that I would clean up the tests since I added those regexps. I plan to > create a patch as soon as this lands. Does that make sense? Yes sure SGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156474/new/ https://reviews.llvm.org/D156474 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
