cjdb added inline comments.
================ Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:3270-3339 + // Instantiate packed data members. + if (FieldDecl *Field = dyn_cast<FieldDecl>(Member); + Field && isa<PackExpansionType>(Field->getType().getTypePtr())) { + QualType PatternType = Field->getType() + ->castAs<PackExpansionType>() + ->getPattern(); + std::optional<unsigned> NumArgumentsInExpansion = ---------------- In order to help improve the readability of this function, I suggest breaking the branches into two separate functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156546/new/ https://reviews.llvm.org/D156546 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits