aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM! In D156201#4551332 <https://reviews.llvm.org/D156201#4551332>, @danix800 wrote: > In D156201#4551270 <https://reviews.llvm.org/D156201#4551270>, @steakhal > wrote: > >> Have you considered back porting this to clang-17? > > How to backport? I'm not familiar with this. Is it plain `cherry-pick` to > specific branch? We have some documented instructions here: https://llvm.org/docs/GitHub.html#backporting-fixes-to-the-release-branches -- I don't oppose adding this to the release branch (it seems simple and straightforward enough), but if it's not fixing a regression or other critical issue, it might make sense to leave it out of 17.x so there's less moving parts during the release. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156201/new/ https://reviews.llvm.org/D156201 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits