balazske accepted this revision. balazske added a comment. This revision is now accepted and ready to land.
The fix looks OK, but the test could be improved and cleaned up (for example `FromClass` is the same as `FromD` in the test, and DeclContext is not checked, can be done like in the test `UndeclaredFriendClassShouldNotBeVisible` but the AST is different). Probably there are other similar cases, and there is a related problem shown in D156693 <https://reviews.llvm.org/D156693> (the fix in that patch is not correct, the solution here is not good for that case, it is possible that the same code as here needs to be changed again or a better fix is found). I am accepting this code but probably will create a new patch to improve and add tests for similar cases (if not done before by somebody else). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155661/new/ https://reviews.llvm.org/D155661 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
