gruuprasad updated this revision to Diff 545807. gruuprasad added a comment.
Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156724/new/ https://reviews.llvm.org/D156724 Files: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp clang/test/Analysis/html_diagnostics/notes-links.cpp Index: clang/test/Analysis/html_diagnostics/notes-links.cpp =================================================================== --- /dev/null +++ clang/test/Analysis/html_diagnostics/notes-links.cpp @@ -0,0 +1,22 @@ +// RUN: rm -fR %t +// RUN: mkdir %t +// RUN: %clang_analyze_cc1 -analyzer-checker=optin.cplusplus.UninitializedObject \ +// RUN: -analyzer-output=html -o %t -verify %s +// RUN: cat %t/report-*.html | FileCheck %s + +struct A { + int *iptr; + int a; // expected-note{{uninitialized field 'this->a'}} + int b; // expected-note{{uninitialized field 'this->b'}} + + A (int *iptr) : iptr(iptr) {} // expected-warning{{2 uninitialized fields at the end of the constructor call [optin.cplusplus.UninitializedObject]}} +}; + +void f() { + A a(0); +} + +//CHECK: <tr><td class="rowname">Note:</td> +//CHECK-NOT: <a href="#Note0"> +//CHECK-SAME: <a href="#Note1">line 9, column 7</a> +//CHECK-SAME: <a href="#Note2">line 10, column 7</a> Index: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp =================================================================== --- clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp +++ clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp @@ -592,11 +592,11 @@ P->getLocation().asLocation().getExpansionLineNumber(); int ColumnNumber = P->getLocation().asLocation().getExpansionColumnNumber(); + ++NumExtraPieces; os << "<tr><td class=\"rowname\">Note:</td><td>" << "<a href=\"#Note" << NumExtraPieces << "\">line " << LineNumber << ", column " << ColumnNumber << "</a><br />" << P->getString() << "</td></tr>"; - ++NumExtraPieces; } }
Index: clang/test/Analysis/html_diagnostics/notes-links.cpp =================================================================== --- /dev/null +++ clang/test/Analysis/html_diagnostics/notes-links.cpp @@ -0,0 +1,22 @@ +// RUN: rm -fR %t +// RUN: mkdir %t +// RUN: %clang_analyze_cc1 -analyzer-checker=optin.cplusplus.UninitializedObject \ +// RUN: -analyzer-output=html -o %t -verify %s +// RUN: cat %t/report-*.html | FileCheck %s + +struct A { + int *iptr; + int a; // expected-note{{uninitialized field 'this->a'}} + int b; // expected-note{{uninitialized field 'this->b'}} + + A (int *iptr) : iptr(iptr) {} // expected-warning{{2 uninitialized fields at the end of the constructor call [optin.cplusplus.UninitializedObject]}} +}; + +void f() { + A a(0); +} + +//CHECK: <tr><td class="rowname">Note:</td> +//CHECK-NOT: <a href="#Note0"> +//CHECK-SAME: <a href="#Note1">line 9, column 7</a> +//CHECK-SAME: <a href="#Note2">line 10, column 7</a> Index: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp =================================================================== --- clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp +++ clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp @@ -592,11 +592,11 @@ P->getLocation().asLocation().getExpansionLineNumber(); int ColumnNumber = P->getLocation().asLocation().getExpansionColumnNumber(); + ++NumExtraPieces; os << "<tr><td class=\"rowname\">Note:</td><td>" << "<a href=\"#Note" << NumExtraPieces << "\">line " << LineNumber << ", column " << ColumnNumber << "</a><br />" << P->getString() << "</td></tr>"; - ++NumExtraPieces; } }
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits