gribozavr2 added a comment.
I understand that this is an expedient fix that silences the warning. However,
the fundamental problem is the simplistic implementation of the warning (that
it is not flow-sensitive), not the inference of nullability. That is, when we
are removing nullability qualifiers, we don't know whether there was a check or
not. So while this change removes some false positives, it also removes some
true positives.
================
Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:3933
// type are ignored for type deduction.
+ // Ignore top level nullability qualifiers too.
ArgType = ArgType.getUnqualifiedType();
----------------
This comment merely duplicates the code. Please add an explanation why it is
done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156728/new/
https://reviews.llvm.org/D156728
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
