aaron.ballman added a comment. In D154328#4542457 <https://reviews.llvm.org/D154328#4542457>, @Hahnfeld wrote:
> Let me see if I can come up a fix for that in `clang-repl` that would then > need this API. But for now, it's also fine for us if the patch stays pending > in review, still better than completely disconnected local commits... Thank you for the explanation! I think it makes sense to hold off on landing this until clang-reply needs to use the API. The code changes themselves look correct to me, so the review should hopefully sail through once there's test coverage exercising the functionality. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154328/new/ https://reviews.llvm.org/D154328 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
