jhuber6 added inline comments.

================
Comment at: clang/test/OpenMP/declare_target_codegen.cpp:264
-// CHECK-DAG: !{i32 1, !"aaa", i32 0, i32 {{[0-9]+}}}
-// CHECK-DAG: !{i32 1, !"ccc", i32 0, i32 {{[0-9]+}}}
 // CHECK-DAG: !{{{.+}}virtual_foo
----------------
tianshilei1992 wrote:
> Since `ccc` is used here, it is not supposed to be removed right?
This is the declare target metadta, which this patch no longer emits for 
external storage variables. Since we assume that whoever defined `ccc` will 
handle it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156368/new/

https://reviews.llvm.org/D156368

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to