cor3ntin marked 2 inline comments as done. cor3ntin added inline comments.
================ Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:60 + "'external_source_symbol' attribute|" + "as argument of '%1' attribute}0">; + ---------------- aaron.ballman wrote: > This duplicates part of `err_attribute_argument_type`; probably worth it to > update that diagnostic so we get consistent diagnostic wording between > attributes expecting string literal arguments. I'm not sure there is a good way to do that without changing thousands of tests. I did look into it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156237/new/ https://reviews.llvm.org/D156237 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
