aaron.ballman added a comment. In D151373#4533550 <https://reviews.llvm.org/D151373#4533550>, @fridtjof wrote:
> I fixed the failing IBOutletCollection.m test - there was code to do special > handling for the respective attribute type, which my patch accidentally > skipped previously. I reordered the generic attribute handling to come after > the special cases in VisitChildren. Nice! > I cleaned up my unit test. After trying a bit to fix it for testing > annotate_type as well, I found out that for some unknown reason it is not > exposed like usual attributes (maybe because it's a type attribute?). > Therefore, I decided to drop it from the test altogether. I think we should drop the `annotate_type` functionality from the patch entirely rather than add it without any test coverage knowing it doesn't seem to work as expected. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151373/new/ https://reviews.llvm.org/D151373 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
