[PATCH] D156378: [clang][CGExprConstant] handle unary negation on integrals

[Nick Desaulniers via Phabricator via cfe-commits]

nickdesaulniers created this revision.
Herald added a project: All.
nickdesaulniers requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Consider the statement:

  int x = -1;

And the following AST:

  `-VarDecl 0x55c4823a7670 <x.c:2:1, col:10> col:5 x 'int' cinit
    `-UnaryOperator 0x55c4823a7740 <col:9, col:10> 'int' prefix '-'
      `-IntegerLiteral 0x55c4823a7720 <col:10> 'int' 1

Return the evaluation of the subexpression negated.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D156378

Files:
  clang/lib/CodeGen/CGExprConstant.cpp


Index: clang/lib/CodeGen/CGExprConstant.cpp
===================================================================
--- clang/lib/CodeGen/CGExprConstant.cpp
+++ clang/lib/CodeGen/CGExprConstant.cpp
@@ -1363,6 +1363,19 @@
     return Visit(E->getSubExpr(), T);
   }
 
+  llvm::Constant *VisitUnaryOperator(UnaryOperator *U, QualType T) {
+    switch (U->getOpcode()) {
+    default:
+      break;
+    case UO_Minus:
+      if (llvm::Constant *C = Visit(U->getSubExpr(), T))
+        if (auto *CI = dyn_cast<llvm::ConstantInt>(C))
+          return llvm::ConstantInt::get(CGM.getLLVMContext(), -CI->getValue());
+      break;
+    }
+    return nullptr;
+  }
+
   // Utility methods
   llvm::Type *ConvertType(QualType T) {
     return CGM.getTypes().ConvertType(T);



Index: clang/lib/CodeGen/CGExprConstant.cpp
===================================================================
--- clang/lib/CodeGen/CGExprConstant.cpp
+++ clang/lib/CodeGen/CGExprConstant.cpp
@@ -1363,6 +1363,19 @@
     return Visit(E->getSubExpr(), T);
   }
 
+  llvm::Constant *VisitUnaryOperator(UnaryOperator *U, QualType T) {
+    switch (U->getOpcode()) {
+    default:
+      break;
+    case UO_Minus:
+      if (llvm::Constant *C = Visit(U->getSubExpr(), T))
+        if (auto *CI = dyn_cast<llvm::ConstantInt>(C))
+          return llvm::ConstantInt::get(CGM.getLLVMContext(), -CI->getValue());
+      break;
+    }
+    return nullptr;
+  }
+
   // Utility methods
   llvm::Type *ConvertType(QualType T) {
     return CGM.getTypes().ConvertType(T);

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits