HazardyKnusperkeks added inline comments.
================ Comment at: clang/lib/Format/ContinuationIndenter.cpp:263 State.StartOfStringLiteral = 0; + State.NoLineBreak = false; State.StartOfLineLevel = 0; ---------------- jp4a50 wrote: > HazardyKnusperkeks wrote: > > Was this uninitialized? > It's a new member variable I added as part of this diff. Sorry, I looked for that, but somehow missed it. ================ Comment at: clang/lib/Format/ContinuationIndenter.cpp:664-666 + if ((Style.Language == FormatStyle::LK_Cpp || + Style.Language == FormatStyle::LK_ObjC) && + !Current.is(tok::comment) && PrevNonComment && ---------------- jp4a50 wrote: > HazardyKnusperkeks wrote: > > Could move this out of the lambda. > Not sure exactly what you're referring to here. Initialization of > `PrevNonComment`? > Not sure exactly what you're referring to here. Initialization of > `PrevNonComment`? No everything in the if before you go into the `PrevNonComment`. It is highlighted if you hover the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156259/new/ https://reviews.llvm.org/D156259 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
