rjmccall added inline comments.
================
Comment at: clang/lib/Parse/ParseObjc.cpp:749
+ if (!Tok.is(tok::eof))
+ ConsumeToken();
break;
----------------
aaron.ballman wrote:
> danix800 wrote:
> > tbaeder wrote:
> > > Why is there a `ConsumeToken()` call at all here? The token is already
> > > being consumed in line 729.
> > Didn't notice this, thanks for reminding!
> I have the same question as @tbaeder -- what token is this intending to
> consume? CC @rjmccall for Obj-C expertise
I don't think any language expertise is required here — just seems like a
straightforward bug on an error path that's probably not exercised all that
often. Maybe somebody moved the `ConsumeToken` and forgot to fix this case or
something.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156277/new/
https://reviews.llvm.org/D156277
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
