jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
LG, address the nits below please.
================
Comment at: clang/lib/CodeGen/CodeGenModule.h:1017
+ return LLVMCompilerUsed;
+ }
+
----------------
Unused now.
================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4941
+ GlobalValue::WeakAnyLinkage,
+ ConstantInt::get(llvm::Type::getInt8Ty(M.getContext()),
+ IsSPMDMode ? OMP_TGT_EXEC_MODE_SPMD
----------------
================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4949-4956
bool OpenMPIRBuilder::checkAndEmitFlushAfterAtomic(
- const LocationDescription &Loc, llvm::AtomicOrdering AO, AtomicKind AK) {
- assert(!(AO == AtomicOrdering::NotAtomic ||
- AO == llvm::AtomicOrdering::Unordered) &&
- "Unexpected Atomic Ordering.");
+ const LocationDescription &Loc, AtomicOrdering AO, AtomicKind AK) {
+ assert(
+ !(AO == AtomicOrdering::NotAtomic || AO == AtomicOrdering::Unordered) &&
+ "Unexpected Atomic Ordering.");
bool Flush = false;
----------------
unrelated. Avoid in this commit, feel free to push a NFC clang-format patch
first.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155794/new/
https://reviews.llvm.org/D155794
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
