tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land.
I'm happy with this. I noted one last rename suggestion to maintain consistency, but am accepting. Please give Corentin a final chance to raise any concerns. Thank you for being so responsive through all the review iterations! ================ Comment at: clang/include/clang/Basic/DiagnosticGroups.td:1210 def MicrosoftInitFromPredefined : DiagGroup<"microsoft-init-from-predefined">; +def MicrosoftStringLiteralFromPredefined : DiagGroup<"microsoft-concat-predefined">; ---------------- We should probably name the diag group to match. - microsoft-concat-predefined -> microsoft-string-literal-from-predefined Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153914/new/ https://reviews.llvm.org/D153914 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
