DiggerLin marked 2 inline comments as done. DiggerLin added inline comments.
================ Comment at: llvm/test/tools/llvm-ranlib/aix-X-option.test:17-18 +## Test the OBJECT_MODE environment variable when adding symbol table. +# RUN: unset OBJECT_MODE +# RUN: llvm-ranlib t_X32.a +# RUN: llvm-nm --print-armap t_X32.a 2>&1 | FileCheck --check-prefixes=GLOB32 --implicit-check-not="in t64" %s ---------------- jhenderson wrote: > Assuming the unsetting is intended to be just for the llvm-ranlib line, I > believe the preferred approach is `env -u OBJECT_MODE llvm-ranlib ...`. That > way, you don't impact the behaviour in subsequent lines. the command `env` of AIX OS do not support -u. and there is no mapping option of `env -u` https://www.ibm.com/docs/en/aix/7.2?topic=e-env-command Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142660/new/ https://reviews.llvm.org/D142660 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
