dblaikie added a comment. Any memory usage measurements to check this doesn't have a significant adverse impact by copying all the strings? (or performance by having to do string rather than pointer equality comparisons?)
Could/should we do the lookup on the CU filename before it goes into the DI metadata, and store that FileID somewhere for later use? Rather than requerying it later/making all queries string comparisons/storing strings, etc? (we could put an "expensive checks" assertion in that our queries always return in agreement with the pointer equality - so in case there are other things that trip over this issue we'll know about them sooner) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155991/new/ https://reviews.llvm.org/D155991 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
