MaskRay added a comment. In D155992#4527081 <https://reviews.llvm.org/D155992#4527081>, @kadircet wrote:
> thanks for doing this! > > as Sam pointed out this will result in invalidation of all the index shards, > but that's not something new. we already don't clean up non-relevant index > shards when people delete sources over time and rely on people having new > checkouts or clearing things up manually. this will be somewhat more severe, > as we'll double the index size all of a sudden. > > but i'd like to keep this patch from landing until llvm-17 is cut (which > should be tomorrow). we didn't have any changes to our index shard > serialization since llvm-16 release, so forcing everyone to face this > invalidation purely for the sake of a clean up that might never happen in the > codebase doesn't feel enough of a justification. whereas it's more likely > that we'll have changes to serialization format throughout the next release > cycle and can hit users only once with big cache invalidations. Sounds good. I'll wait after the branch (today) :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155992/new/ https://reviews.llvm.org/D155992 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
