MaskRay added inline comments.
================
Comment at: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp:881
+ std::string KindStr = Prefix + "-" + Kind;
+
Diags.Report(diag::err_verify_inconsistent_diags).setForceEmit()
----------------
The variables are immediately used. I think in this case our convention is omit
the blank line (and in general I think we omit blank lines for many more cases,
compared to some other projects (GNU, Linux kernel, etc)).
================
Comment at: clang/test/Frontend/verify.c:159
+
+// what-error {{huh?}}
+// CHECK9: error: 'what-error' diagnostics expected but not seen:
----------------
This may need a comment explaining that this is not recognized as a directive.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154688/new/
https://reviews.llvm.org/D154688
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
