amyk added a comment.

In D155544#4523536 <https://reviews.llvm.org/D155544#4523536>, 
@hubert.reinterpretcast wrote:

> Patch should not land before back-end patch. I also suggest having the patch 
> incorporate the new option into the Clang release notes before it lands.

I'm currently addressing reviews for the back-end patch but just wanted to 
clarify because I might be misunderstanding something.

Wouldn't this patch need to land before the back-end patch, because I introduce 
the option here, and then I use it in the backend patch?
In terms of checking for a 32-bit diagnostic within 
`check-aix-small-local-exec-tls-opt.ll`, the RUN lines in that test currently 
are 64-bit RUN lines. Perhaps in the backend patch, I should just add the 
32-bit lines to show the diagnostic?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155544/new/

https://reviews.llvm.org/D155544

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to