carlosgalvezp added inline comments.
================ Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:62 + return N != nullptr && (isTopLevelNamespaceWithName(*N, "base") || + isTopLevelNamespaceWithName(*N, "folly")); } ---------------- gribozavr2 wrote: > carlosgalvezp wrote: > > If there's no need for `absl` here, why do we need to add `folly`? > This is the branch for `RD.getName() == "Optional"` with a capital "O" > because `base::Optional`, `folly;:Optional` are spelled with a capital "O". > > Abseil provides `absl::optional` and it is handled under `RD.getName() == > "optional"` together with `std::optional` above. Got it, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155890/new/ https://reviews.llvm.org/D155890 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
