tbaeder added inline comments.

================
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:234
 
+  if (!LT || !RT || !T)
+    return this->bail(BO);
----------------
aaron.ballman wrote:
> Should we be checking `!T` earlier (it's used within the `Discard` lambda 
> with an unprotected dereference)?
Probably, but I changed this again a bit in https://reviews.llvm.org/D148925, 
so I'd like to do that change in a later commit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144164/new/

https://reviews.llvm.org/D144164

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to