pengfei added inline comments.
================ Comment at: clang/test/Preprocessor/predefined-arch-macros.c:2496 // CHECK_SRF_M32: #define __PTWRITE__ 1 +// CHECK_GRR_M32: #define __RAOINT__ 1 // CHECK_SRF_M32: #define __RDPID__ 1 ---------------- This is easy to be confused. How about add a not check? e.g., ``` ... -check-prefix=CHECK_SRF_GRR_M32,CHECK_SRF_M32 ... -check-prefixes=CHECK_SRF_GRR_M32,CHECK_GRR_M32 ... // CHECK_SRF_GRR_M32: #define __PTWRITE__ 1 // CHECK_SRF_M32-NOT: __RAOINT__ // CHECK_GRR_M32: #define __RAOINT__ 1 ``` ================ Comment at: clang/test/Preprocessor/predefined-arch-macros.c:2568 // CHECK_SRF_M64: #define __PTWRITE__ 1 +// CHECK_GRR_M64: #define __RAOINT__ 1 // CHECK_SRF_M64: #define __RDPID__ 1 ---------------- ditto. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155784/new/ https://reviews.llvm.org/D155784 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
