jacquesguan added a comment. In D151547#4514424 <https://reviews.llvm.org/D151547#4514424>, @asb wrote:
> I remain concerned about exposing the intrinsics if they're not yet agreed as > finalised. I see there is now a PR to add them to riscv-c-api doc > https://github.com/riscv-non-isa/riscv-c-api-doc/pull/47 > > I'd be OK with merging this now if the intrinsics were temporarily removed, > or logic were added to gate them in some way (though we don't have precedent > on the best way to do this I don't think). Otherwise, I'd rather wait until > the intrinsics are agreed. I saw that https://github.com/riscv-non-isa/riscv-c-api-doc/pull/47 is basically agreed and close to merge, I think we could wait it to avoid repeat patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151547/new/ https://reviews.llvm.org/D151547 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
