zahiraam added inline comments.
================ Comment at: clang/test/CodeGen/math-errno.c:28 +// FAST-LABEL: define dso_local nofpclass(nan inf) float @f1 +// FAST: call fast nofpclass(nan inf) float @sqrtf(float noundef nofpclass(nan inf) {{.*}}) #[[ATTR3_FAST:[0-9]+]] +// ---------------- andrew.w.kaylor wrote: > Shouldn't the precise pragma remove the nofpcalss(nan inf) attributes? The > definition of setFPPreciseEnabled looks like it's trying to do that. Maybe we > need another patch to handle that? > Shouldn't the precise pragma remove the nofpcalss(nan inf) attributes? The > definition of setFPPreciseEnabled looks like it's trying to do that. Maybe we > need another patch to handle that? I will make a note of it and work on it in a subsequent patch. ================ Comment at: clang/test/CodeGen/math-errno.c:40 +// CHECK-LABEL: define dso_local float @f2 +// CHECK: tail call float @llvm.sqrt.f32(float {{.*}}) + ---------------- andrew.w.kaylor wrote: > Again, this may be beyond the scope of your change, but it seems like > '#pragma float_control(precise, off) should lead to fast-math flags being set > on this call. > Again, this may be beyond the scope of your change, but it seems like > '#pragma float_control(precise, off) should lead to fast-math flags being set > on this call. Yes. Making a note of it. ================ Comment at: clang/test/CodeGen/math-errno.c:2 +// Tests that at -O2 math-errno is taken into account. Same than MSVC. +// RUN: %clang_cc1 -Wno-implicit-function-declaration -fmath-errno \ +// RUN: -O2 -emit-llvm -o - %s \ ---------------- andrew.w.kaylor wrote: > Isn't math-errno true by default when fast-math isn't used? Yes, that's correct. This RUN line simulates compilation at -O2. The following cc1 options are triggered: -fmath-errno -ffp-contract=on -fno-rounding-math -O2. That's what I am using here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.org/D151834 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits