ldionne added inline comments.
================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1515
const NamedDecl *D) const {
- if (D && D->isExternallyVisible()) {
+ if (D && D->isExternallyVisible() &&
!D->hasAttr<ExcludeFromExplicitInstantiationAttr>()) {
if (D->hasAttr<DLLImportAttr>())
----------------
To be perfectly honest, I searched for `DLLImportAttr` until I found places
that made some amount of sense to exclude when the entity has
`ExcludeFromExplicitInstantiationAttr`, but there might be much deeper
consequences to those changes that I don't understand. I'm very naive when it
comes to Clang, especially when it comes to codegen. So I recommend really
looking over these changes or we might be making things worse.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155713/new/
https://reviews.llvm.org/D155713
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
