shafik added a comment. I think this looks fine, I just wonder if we should be adding more tests to make sure we cover the a fuller set of types and non-type template parameters. I feel like this is always what bites us when bugs come up, if we had just test more carefully we would have caught the problem earlier.
CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154366/new/ https://reviews.llvm.org/D154366 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
