FreddyYe added inline comments.
================ Comment at: clang/lib/Headers/sm3intrin.h:230 +/// \endcode +#define _mm_sm3rnds2_epi32(A, B, C, D) \ + (__m128i) __builtin_ia32_vsm3rnds2((__v4su)A, (__v4su)B, (__v4su)C, (int)D) ---------------- pengfei wrote: > Missing `__` for variables. MACROs prefer no __ for prefix and the operation defines A, B, C, ... So I used another naming convention in doxygen for parameters. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/new/ https://reviews.llvm.org/D155147 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
