RKSimon added inline comments.
================ Comment at: clang/lib/Headers/sm4intrin.h:17 + +#define _mm_sm4key4_epi32(A, B) \ + (__m128i) __builtin_ia32_vsm4key4128((__v4su)A, (__v4su)B) ---------------- doxygen descriptions? ================ Comment at: clang/test/CodeGen/X86/sm4-builtins.c:5 +#include <immintrin.h> +#include <stddef.h> + ---------------- what is stddef.h needed for? ================ Comment at: llvm/test/MC/Disassembler/X86/sm4-64.txt:4 +# RUN: llvm-mc --disassemble %s -triple=x86_64 | FileCheck %s --check-prefixes=ATT +# RUN: llvm-mc --disassemble %s -triple=x86_64 -x86-asm-syntax=intel --output-asm-variant=1 | FileCheck %s --check-prefixes=INTEL + ---------------- skan wrote: > Remove -x86-asm-syntax=intel As with sm3 - keep the 64-bit tests but make sure we have at least some test coverage with x86_64 specific registers (ymm8..ymm15 / r8..r15 etc.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155148/new/ https://reviews.llvm.org/D155148 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
