oskarwirga added inline comments.
================ Comment at: clang/lib/CodeGen/CGExpr.cpp:3594 + TrapCall->addFnAttr(A); + } + TrapCall->setDoesNotReturn(); ---------------- aeubanks wrote: > oskarwirga wrote: > > vitalybuka wrote: > > > wouldn't be you issues solved with > > > TrapCall->setCannotMerge() here? > > ubsantrap gets lowered to an instruction in MIR which then gets merged > > later. This was the only way I was able to create unique instruction per > > check. > isn't that a `nomerge` bug that should get fixed instead? I don't think so because nomerge is a function attribute and the ubsantrap intrinsic gets lowered as an instruction. Creating instruction attributes from lowered function attributes seems a bit involved to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148654/new/ https://reviews.llvm.org/D148654 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
