arichardson added a comment. In D153989#4492342 <https://reviews.llvm.org/D153989#4492342>, @phosek wrote:
> In D153989#4492229 <https://reviews.llvm.org/D153989#4492229>, @arichardson > wrote: > >> I think reduplication of build logic makes sense but these are conceptually >> separate things. The compiler rt builtins are needed in many cases where the >> C start-up code isn't (e.g. baremetal OS code). Would moving it to a >> subdirectory of builtins/ work too? That way it's clearer which source files >> and tests are part of each component? > > That's certainly possible, although I'd also argue that `crtbegin.c` and > `crtend.c` isn't the only code in builtins directory that fits into this > category (that is not needed in environments like baremetal, requiring C > library): for example `atomic*.c`, `os_version_check.c`, `emutls.c`, > `enable_execute_stack.c`, `eprintf.c`, `gcc_personality_v0.c`, > `clear_cache.c` and probably some more that I missed. If we're going to > reorganize things, we should probably do it more holistically. That is a good point and it would be nice to have more subdirectories (e.g. atomic should end up in libatomic.a). I was just suggesting subdirectories for this change since we already have an existing hierarchy that could be retained. Splitting things out later is slightly more involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153989/new/ https://reviews.llvm.org/D153989 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
