ldionne added inline comments.
================ Comment at: llvm/docs/DeveloperPolicy.rst:359 + If the patch fixes a bug in GitHub Issues, we encourage adding + "Fixes https://github.com/llvm/llvm-project/issues/12345"; to automate closing + the issue in GitHub. If the patch has been reviewed, we encourage adding a ---------------- smeenai wrote: > aaron.ballman wrote: > > arsenm wrote: > > > I haven't quite figured out what the exact syntaxes which are > > > automatically recognized. It seems to recognize "Fixes #Nxyz" > > Yup, it does support that form as well. I had heard more than once during > > code review that folks seem to prefer the full link because it's easier to > > click on that from the commit message than it is to navigate to the fix > > from the number alone. That seemed like a pretty good reason to recommend > > the full form, but I don't have strong opinions. > +1 for encouraging the full link Perhaps we could encourage using `https://llvm.org/PR12345` instead? Does anybody know whether `llvm.org/PRXXX` is something that we intend to keep around with the Github transition or not? ================ Comment at: llvm/docs/DeveloperPolicy.rst:363-364 `here <https://www.llvm.org/docs/Phabricator.html#committing-a-change>`_. + Other kinds of metadata are also acceptable, including links to resources + that are not available to the entire community. ---------------- Do you think this adds a useful reminder? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155081/new/ https://reviews.llvm.org/D155081 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
