steakhal added inline comments.

================
Comment at: clang/test/Analysis/stream-note.c:61-62
   FILE *F1 = fopen("foo1.c", "r"); // expected-note {{Stream opened here}}
+  // stdargs-note@-1 {{'fopen' is successful}}
+  // stdargs-note@-2 {{'fopen' is successful}}
   if (!F1)
----------------
steakhal wrote:
> balazske wrote:
> > steakhal wrote:
> > > Why are these notes doubled?
> > There are 2 cases of resource leak reported (for `F1` and `F2`) and a note 
> > tag is there for both of these.
> I still think we should only have a single note there given that `F2` is 
> completely unrelated to the initialization of `F1`.
> Do I miss something?
Oo, now I see. D153776 is supposed to fix limit the notes to be displayed only 
for the interesting values. nvm.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153612/new/

https://reviews.llvm.org/D153612

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to