hokein marked an inline comment as done. hokein added inline comments.
================ Comment at: clang/lib/Tooling/Inclusions/HeaderIncludes.cpp:369-370 + QuotedName, /*CheckMainHeader=*/!MainIncludeFound); + if (Priority == 0) + MainIncludeFound = true; auto CatOffset = CategoryEndOffsets.find(Priority); ---------------- kadircet wrote: > sorry if I was unclear in the previous comment. but i was trying to say we > should only consider includes we've encountered during the initial scan. > > getting different results depending on the order of insertions being > performed is likely gonna cause confusion elsewhere (e.g. depending on the > first diagnostic you've in clangd, you'll get different order of includes). > hence, let's keep this function stateless (which also gets rid of the > concerns around mutable) sorry for misunderstanding your comment. Make it stateless looks like a good idea. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154963/new/ https://reviews.llvm.org/D154963 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
