MaskRay added inline comments.
================
Comment at: clang/test/Driver/lto-aix.c:76
// CSPGO: "-bplugin_opt:-cs-profile-generate"
"-bplugin_opt:-cs-profile-path=default_%m.profraw"
+//
+// Test integrated assembler options
----------------
This `^//$` line is not useful. Some tests use this style, but it's not a good
style.
If we remove this line, we can actually use Vim `{` `}` navigate among tests.
================
Comment at: clang/test/Driver/lto-aix.c:79
+// RUN: %clang --target=powerpc-ibm-aix -### %s -flto -fno-integrated-as \
+// RUN: -fintegrated-as 2>&1 | FileCheck --check-prefix=INTAS %s
+// RUN: %clang --target=powerpc-ibm-aix -### %s -flto -fintegrated-as \
----------------
2-space indentation
================
Comment at: llvm/test/tools/llvm-lto/aix-sys-as.ll:12
+; CHECK: Wrote native object file
+
----------------
delete trailing blank line
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152924/new/
https://reviews.llvm.org/D152924
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
