cor3ntin added a comment. In D105759#4482543 <https://reviews.llvm.org/D105759#4482543>, @barannikov88 wrote:
> @cor3ntin > I've been working on pretty much the same functionality in our downstream > fork. I was not aware of the paper, nor of the ongoing work in this > direction, and so I unfortunately missed the review. > Thanks for this patch, it significantly reduces the number of changes > downstream and makes it easier to merge with upstream in the future. > > I have a couple of questions about future work: > > - IIUC the paper initially addressed this issue with `#line` directive, but > the changes were reverted(?). Is there any chance they can get back? There is a core issue tracking that, ie the c++ committee was concerned about escape sequences in header names https://www.open-std.org/jtc1/sc22/wg21/docs/cwg_active.html#2693 I'd be happy to bring that back to clang though, as the concerned is unlikely to be warranted for us. > - Are there any plans for making similar changes to asm statement parsing? The direction of the c++ committee is that what's in `asm()` is now strictly implementation-defined, so we could but last time there were concerns about escape sequences in there too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
