ADKaster planned changes to this revision.
ADKaster added a comment.
Planning to rebase on top of Generic_ELF per Petr's suggestion.
================
Comment at: clang/lib/Driver/ToolChains/Serenity.cpp:85
+ auto linkerIs = [Exec](const char *name) {
+ return llvm::sys::path::filename(Exec).equals_insensitive(name) ||
+ llvm::sys::path::stem(Exec).equals_insensitive(name);
----------------
MaskRay wrote:
> Avoid `equals_insensitive`. It's only recommended in some places for Windows.
What is the recommendation for this use case instead? This is the same pattern
that is used by the Fuchsia driver.
https://github.com/llvm/llvm-project/blob/01e3393b94d194ee99e57f23f9c08160cef94753/clang/lib/Driver/ToolChains/Fuchsia.cpp#L59-L61
though it looks like Fuchsia used that pattern back when it was called
`equals_lower()`.
https://github.com/llvm/llvm-project/commit/3e199ecdadf7b546054c5a5820d1678f1e83c821
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154396/new/
https://reviews.llvm.org/D154396
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
