[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

[Matt Arsenault via Phabricator via cfe-commits]

arsenm added inline comments.


================
Comment at: clang/tools/amdgpu-arch/AMDGPUArch.cpp:50
+#else
+  return printGPUsByHSA();
+#endif
----------------
The HIP path should work on linux too. I generally think we should build as 
much code as possible on all hosts, so how about
```
#ifndef _WIN32
  if (tryHSA())
    return 0;
#endif

tryHIP()
```





CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153725/new/

https://reviews.llvm.org/D153725

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits