donat.nagy added a comment.
In D153954#4480296 <https://reviews.llvm.org/D153954#4480296>, @steakhal wrote:
> [...] I'd not recommend moving the actual implementation anywhere.
I agree, I mostly spoke figuratively, suggesting that this checker could end up
in the optin group when it's eventually brought out of alpha.
================
Comment at: clang/test/Analysis/enum-cast-out-of-range.cpp:44
+ // Suppress unused warnings
+ [](...){}(unscoped, scoped);
+ }
----------------
steakhal wrote:
> `void sink(...);` would have achieved the same and I'd say it's less complex.
> `sink(unscoped, scoped);`
Or just `(void)unscoped; (void)scoped;` if we're bikeshedding this test...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153954/new/
https://reviews.llvm.org/D153954
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
