aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM. thank you! In D153296#4480243 <https://reviews.llvm.org/D153296#4480243>, @hokein wrote: > In D153296#4480141 <https://reviews.llvm.org/D153296#4480141>, @yronglin > wrote: > >> In D153296#4479718 <https://reviews.llvm.org/D153296#4479718>, @hokein wrote: >> >>> Thanks, this looks good. >> >> Thanks for your review! I don't know why the reversion status still `Needs >> Review`, and the `libcxx ci` often fails to start. > > I guess the `Needs Review` is probably caused by the previous "Requested > Changes" by Aaron. Correct. > The `libcxx ci` failure doesn't seem to be relevant. I think we're all on the > same page about the fix, it is fine to land it assuming that the `ninja > check-clang` passes. Agreed, the libcxx failure is unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153296/new/ https://reviews.llvm.org/D153296 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
