donat.nagy accepted this revision. donat.nagy added a comment. This revision is now accepted and ready to land.
LGTM. ================ Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:413-414 + using ValueConstraint::ValueConstraint; + ArgNo SizeArg1N; + std::optional<ArgNo> SizeArg2N; + // This variable has a role when we negate the constraint. ---------------- What would you think about a `SmallVector<2>` for these? It would allow you to handle them with a (short) for loop instead of separate commands. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154509/new/ https://reviews.llvm.org/D154509 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits